Add support for the custom attributes #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
requested review from
CarlosGamero,
drdaemos and
a team
as code owners
kibertoad
commented
Dec 15, 2024
| @@ -50,6 +51,17 @@ export class NewRelicTransactionManager implements TransactionObservabilityManag | |||
| newrelic.addCustomAttribute(attrName, attrValue) | |||
| } | |||
|
|
|||
| public addCustomAttributes( | |||
| _uniqueTransactionKey: string, | |||
There was a problem hiding this comment.
signature of the method still includes this parameter because other implementations (Prometheus, OpenTelemetry etc) will need it
kibertoad
commented
Dec 15, 2024
| const transactionName = this.transactionNameByKey.get(uniqueTransactionKey) | ||
| if (!transactionName) return | ||
|
|
||
| // @ts-expect-error We only enforce types lightly here. If this ever causes us problem, we can start doing runtime validation here, but it seems to be an overkill for now. |
There was a problem hiding this comment.
maybe we also should extend the interface of TransactionObservabilityManager to have a generic for customAttribute keys, but that could be a future improvement
kibertoad
commented
Dec 15, 2024
| [ | ||
| '# HELP myMetric this is my first metric', | ||
| '# TYPE myMetric counter', | ||
| 'myMetric{status="started",transactionName="myTransaction"} 1', |
There was a problem hiding this comment.
we would need to change the signature of the base interface start method if we want to make it possible to also include custom attributes there. maybe we should do that after we have the first use-case for it
CarlosGamero
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This implements a new method on the transactionObservabilityManager
Checklist
major,minor,patchorskip-release