Skip to content

Commit

Permalink
table: Revert deferred render scrollbr for table.
Browse files Browse the repository at this point in the history
This will make scrollbar on the top, even there have other element cover
it.
  • Loading branch information
huacnlee committed Jan 12, 2025
1 parent 9eba97d commit 658113f
Showing 1 changed file with 10 additions and 15 deletions.
25 changes: 10 additions & 15 deletions crates/ui/src/table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ use crate::{
Icon, IconName, Sizable, Size, StyleSized as _,
};
use gpui::{
actions, canvas, deferred, div, prelude::FluentBuilder, px, uniform_list, AppContext, Axis,
Bounds, Div, DragMoveEvent, Edges, Entity, EntityId, EventEmitter, FocusHandle, FocusableView,
actions, canvas, div, prelude::FluentBuilder, px, uniform_list, AppContext, Axis, Bounds, Div,
DragMoveEvent, Edges, Entity, EntityId, EventEmitter, FocusHandle, FocusableView,
InteractiveElement, IntoElement, KeyBinding, ListSizingBehavior, MouseButton, ParentElement,
Pixels, Point, Render, ScrollHandle, ScrollStrategy, SharedString, Stateful,
StatefulInteractiveElement as _, Styled, UniformListScrollHandle, ViewContext,
Expand Down Expand Up @@ -1249,19 +1249,14 @@ where
|_, _, _| {},
))
.child(
// use deferred to render the scrollbar for
// avoid some custom element overflow the scrollbar.
deferred(
div()
.absolute()
.top_0()
.size_full()
.child(self.render_horizontal_scrollbar(cx))
.when(rows_count > 0, |this| {
this.children(self.render_scrollbar(cx))
}),
)
.with_priority(0),
div()
.absolute()
.top_0()
.size_full()
.child(self.render_horizontal_scrollbar(cx))
.when(rows_count > 0, |this| {
this.children(self.render_scrollbar(cx))
}),
)
// Click out to cancel right clicked row
.when(self.right_clicked_row.is_some(), |this| {
Expand Down

0 comments on commit 658113f

Please sign in to comment.