Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panel: Update Panel toolbar_buttons method to use ViewContext<Self>. #536

Merged
merged 2 commits into from
Jan 9, 2025
Merged

panel: Update Panel toolbar_buttons method to use ViewContext<Self>. #536

merged 2 commits into from
Jan 9, 2025

Conversation

huacnlee
Copy link
Member

@huacnlee huacnlee commented Jan 9, 2025 •
edited
Loading

Break changes

The toolbar_buttons trait method in Panel has been changed:

- fn toolbar_buttons(&self, cx: &WindowContext) -> Vec<Button>
+ fn toolbar_buttons(&self, cx: &mut ViewContext<Self>) -> Option<Vec<Button>>

@huacnlee huacnlee changed the title panel: Improve Panel toolbar_buttons method to use ViewContext<Self>. panel: Update Panel toolbar_buttons method to use ViewContext<Self>. Jan 9, 2025
@huacnlee huacnlee merged commit de42cc4 into main Jan 9, 2025
2 checks passed
@huacnlee huacnlee deleted the panel-1 branch January 9, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huacnlee