Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix for fluctuating checksum #188

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9305

What this PR does / why we need it:

This reverts the commit related to the race condition issue that triggered the fluctuating checksums. We're keeping this PR open for reproduction purposes.

Special notes for your reviewer:

None

Additional documentation or context

longhorn/longhorn#6613

This reverts commit d330ae2.

longhorn/longhorn-9305

Signed-off-by: Chin-Ya Huang <[email protected]>
@c3y1huang c3y1huang force-pushed the feat-v2-dr-volume-fluctuating-checksum branch from 14096a2 to 5cc2e81 Compare August 28, 2024 03:53
@c3y1huang c3y1huang changed the title Revert "feat(v2): update final progress after device is closed" revert: "feat(v2): update final progress after device is closed" Aug 28, 2024
@c3y1huang c3y1huang changed the title revert: "feat(v2): update final progress after device is closed" revert: fix for fluctuating checksum Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.86%. Comparing base (fe89e48) to head (5cc2e81).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #188   +/-   ##
======================================
  Coverage    7.86%   7.86%           
======================================
  Files          23      23           
  Lines        2010    2010           
======================================
  Hits          158     158           
  Misses       1826    1826           
  Partials       26      26           
Flag Coverage Δ
unittests 7.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant