fix: do not send upgrade check requests if the current version is a dev

version This will prevent the upgrade responder from having too many tags which can be a performance issue Signed-off-by: Phan Le <[email protected]>
longhorn · Sep 25, 2024 · a9d117f · a9d117f
1 parent 3ac6b93
commit a9d117f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/controller/setting_controller.go b/controller/setting_controller.go
@@ -39,6 +39,7 @@ import (
 
 	"github.com/longhorn/longhorn-manager/constant"
 	"github.com/longhorn/longhorn-manager/datastore"
+	"github.com/longhorn/longhorn-manager/meta"
 	"github.com/longhorn/longhorn-manager/types"
 	"github.com/longhorn/longhorn-manager/util"
 
@@ -1326,6 +1327,8 @@ func (sc *SettingController) syncUpgradeChecker() error {
 		return err
 	}
 
+	isDevVersion := strings.Contains(meta.Version, "dev")
+
 	latestLonghornVersion, err := sc.ds.GetSetting(types.SettingNameLatestLonghornVersion)
 	if err != nil {
 		return err
@@ -1335,7 +1338,7 @@ func (sc *SettingController) syncUpgradeChecker() error {
 		return err
 	}
 
-	if !upgradeCheckerEnabled {
+	if !upgradeCheckerEnabled || isDevVersion {
 		if latestLonghornVersion.Value != "" {
 			latestLonghornVersion.Value = ""
 			if _, err := sc.ds.UpdateSetting(latestLonghornVersion); err != nil {