-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(1.8.0): auto-salvage support for v2 volumes #994
Draft
c3y1huang
wants to merge
1
commit into
longhorn:master
Choose a base branch
from
c3y1huang:8430-feat-v2-auto-salvage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longhorn/longhorn-8430 Signed-off-by: Chin-Ya Huang <[email protected]>
c3y1huang
force-pushed
the
8430-feat-v2-auto-salvage
branch
from
September 24, 2024 01:42
01371f4
to
104868c
Compare
✅ Deploy Preview for longhornio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jhkrug
requested changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A typo.
@@ -230,6 +231,8 @@ Before Longhorn v1.7.0, Longhorn block-type disks only supported the SPDK AIO bd | |||
|
|||
Filesystem trim is supported since Longhorn v1.7.0. If a disk is managed by the SPDK AIO bdev driver, the Trim (UNMAP) operation is not recommended in a production environment (ref). It is recommended to manage a block-type disk with an NVMe bdev driver. | |||
|
|||
Staring with Longhorn v1.8.0, filesystem trim is blocked when the the targeting v2 volume is in a degraded state. This ensures the reliability of the volume head size during the [auto-salvage](#auto-salvage-volumes) operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Staring with Longhorn v1.8.0, filesystem trim is blocked when the the targeting v2 volume is in a degraded state. This ensures the reliability of the volume head size during the [auto-salvage](#auto-salvage-volumes) operation. | |
Starting with Longhorn v1.8.0, filesystem trim is blocked when the the targeting v2 volume is in a degraded state. This ensures the reliability of the volume head size during the [auto-salvage](#auto-salvage-volumes) operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#8430
What this PR does / why we need it:
Add important notes about auto-salvage support for v2 volumes.
Special notes for your reviewer:
None
Additional documentation or context
longhorn/longhorn#9486