Don't throw runtime error on missing assets #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neznaika0, apparently this behavior was expected (as the test I had to change indicates). But our case, where asset name might depend on some dynamic variable, shows that it might not be the best expectation. Anyway, we have to ask @lonnieezell if we can proceed with this change. |
lonnieezell
approved these changes
Feb 5, 2025
|
@lonnieezell, thanks for review. To compensate for not breaking early I have added a log message - warning - on missing asset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing assets currently terminate page execution in runtime exception. Since asset is external file, it being missing should not be the cause of breaking the page itself.
With these changes, when a missing asset is encountered, a string with a missing asset notice is produced, like:
https://example.com/assets/admin/js/tinymce6-ru~~asset-is-missing.js
This PR closes issue #538