Skip to content

Commit

Permalink
WIP add failing tests for issue #32 (but I am failing to do it correc…
Browse files Browse the repository at this point in the history
…tly at the moment...)
  • Loading branch information
fabio-looker committed Feb 5, 2020
1 parent 2d68556 commit 2b05254
Show file tree
Hide file tree
Showing 3 changed files with 69 additions and 0 deletions.
11 changes: 11 additions & 0 deletions __tests__/dummy-projects/07-issue-32/bad.model.lkml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
view: bad_view {
dimension: foo {
sql: TRUE ;;
html:
{% if linkback_type._parameter_value == "Client" %}
<p>Thank you for logging in!</p>
<p><a href="https://<redacted>/client/{{ client_id._parameter_value | replace:'$','-' }}">Return to dashboard</a></p>
{% endif %}
;;
}
}
47 changes: 47 additions & 0 deletions __tests__/dummy-projects/07-issue-32/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
const lams = require('../../../index.js')
const mocks = require('../../../lib/mocks.js')
const path= require('path')
const options = {reporting:"no", cwd:__dirname, onParserError:"fail"}
require('../../../lib/expect-to-contain-message');
const log = x=>console.log(x)
const testProjectName = __dirname.split(path.sep).slice(-1)[0];

describe('Projects', () => {
describe(testProjectName, () => {
let {spies, process, console} = mocks()
let messages
beforeAll( async () => {
messages = await lams(options,{process, console})
log(messages)//.filter(m=>m.rule=="F1"))
})
it("bad.model should error on rule F1", ()=> {
expect(console.error).not.toHaveBeenCalled();
expect(process.exit).not.toHaveBeenCalled();
expect({messages}).toContainMessage({
rule: "F1",
level: "error",
location: "model:bad/view:bad_view/dimension:foo"
});
});
it("ok.model should not error/warn on rule F1", ()=> {

expect(console.error).not.toHaveBeenCalled();
expect(process.exit).not.toHaveBeenCalled();
// expect({messages}).toContainMessage({
// rule: "F1",
// level: "info",
// location: "model:ok/view:ok_view/dimension:foo"
// });
expect({messages}).not.toContainMessage({
rule: "F1",
level: "error",
location: "model:ok/view:ok_view/dimension:foo"
});
expect({messages}).not.toContainMessage({
rule: "F1",
level: "warning",
location: "model:ok/view:ok_view/dimension:foo"
});
});
});
});
11 changes: 11 additions & 0 deletions __tests__/dummy-projects/07-issue-32/ok.model.lkml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
view: ok_view {
dimension: foo {
sql: ${actual.cross_view_reference} ;;
html:
{% if linkback_type._parameter_value == "Client" %}
<p>Thank you for logging in!</p>
<p><a href="https://<redacted>/client/{{ client_id._parameter_value | replace:'$','-' }}">Return to dashboard</a></p>
{% endif %}
;;
}
}

0 comments on commit 2b05254

Please sign in to comment.