Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PBR textures to New Legion condition #3002

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Add PBR textures to New Legion condition #3002

merged 2 commits into from
Jan 26, 2025

Conversation

langfod
Copy link
Contributor

@langfod langfod commented Jan 12, 2025

Adds to texture check condition the paths for PBR textures from NordwarUA's Legion - Complex Material and PBR
https://www.nexusmods.com/skyrimspecialedition/mods/137994

Note that "DIS_Heavy_Legion.esp" can also refer to esp replacer from RMB SPIDified - New Legion (https://www.nexusmods.com/skyrimspecialedition/mods/84974)

But it is also from: "Heavy Legion SSE" - https://www.nexusmods.com/skyrimspecialedition/mods/22877
( and RMB SPIDified - Heavy Legion - https://www.nexusmods.com/skyrimspecialedition/mods/101461)
Textures paths would be:
\Textures\1_Soldier_Replacer
\Textures\pbr\1_Soldier_Replacer

Not sure if should just add those paths.

@pStyl3
Copy link
Member

pStyl3 commented Jan 17, 2025

The proposed change seems fine to me, in regards to NordwarUA's Legion - Complex Material and PBR.

Both Heavy Legion SSE and RMB SPIDified - Heavy Legion include a HeavyLegion.esp but as far as I can see, no DIS_Heavy_Legion.esp, and as such I think we wouldn't need to take those mods into consideration for this PR. Why do you think that these mods include DIS_Heavy_Legion.esp?

@langfod
Copy link
Contributor Author

langfod commented Jan 18, 2025

as far as I can see, no DIS_Heavy_Legion.esp, and as such I think we wouldn't need to take those mods into consideration for this PR. Why do you think that these mods include DIS_Heavy_Legion.esp?

My mistake on that inclusion

@pStyl3 pStyl3 merged commit 068e383 into loot:v0.21 Jan 26, 2025
1 check passed
@pStyl3
Copy link
Member

pStyl3 commented Jan 26, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants