Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Issue #119) Remove return value from reinit screen #129

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lucas-james
Copy link
Contributor

@lucas-james lucas-james commented Sep 19, 2018

Related to the following issue: 9afb94d

Based on the work in the following branch:
#123
the reinit_screen function actually no longer needs a return value (only the last commit here adds anything) 👍

sounds.fire.play()
game.bullets.append(game.player.fire())
if key == keys.RETURN:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return is an odd choice for a pause key. Perhaps P instead of return?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants