feat: Adds ability to use ContainerID to persist prosemirror document to. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I made a few fixes on this branch. Please allow me to push to your branch (the use of commit's (I should set up a prettier/eslint config for this. It's too hard to find the difference.) |
|
Sure thing! Forgot to mention I also added the ability to provide a user object that renders the awareness cursor with a custom name and color. And my bad for the formatting changes, I originally wrote this in my own project and copied it over to this fork. |
|
I saw that! Thanks. If it's too troublesome to set the permission, you can merge the branch called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional prop to the SyncPlugin so that users can specify a ContainerID to write the prosemirror document to instead of
doc.getMap(ROOT_DOC_KEY). This way users can initialize their LoroDoc and write to a nested container. Also updated the storybook example to use the new export and added a Broadcast Channel example so if you have two tabs side by side, contents will sync.