fix page high bug about parent page and report bug about leaf page #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid possible errors like:
Traceback (most recent call last):
File "inspector/command.py", line 51, in <module>
main(sys.argv[1:])
File "inspector/command.py", line 47, in main
render_tree(tree, file_path)
File "/root/pageinspect_inspector/inspector/renderer.py", line 29, in render_tree
html_file.write(template.render(tree=tree))
File "/usr/local/lib/python3.7/site-packages/Jinja2-3.0.3-py3.7.egg/jinja2/environment.py", line 1291, in render
self.environment.handle_exception()
File "/usr/local/lib/python3.7/site-packages/Jinja2-3.0.3-py3.7.egg/jinja2/environment.py", line 925, in handle_exception
raise rewrite_traceback_stack(source=source)
File "/root/pageinspect_inspector/inspector/templates/render_tree.html", line 282, in top-level template code
{% include 'render_page.html' %}
File "/root/pageinspect_inspector/inspector/templates/render_page.html", line 28, in top-level template code
[{% for val in item.value %}
TypeError: 'NoneType' object is not iterable
Filtering on index_type was not working in render_page.html due to this issue.
adding empty value in retrieve_items and replace type with index_type in class Tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR contains 4 commits to solve 3 issues I've encountered when using this great tool 😃
Thanks
yoa
The first two commit is about adding empty value in retrieve_items and replace type with index_type in class Tree #1.
The third commit is about displaying page high key and blank key in parent page.
The fourth commit is about displaying page high key in leaf page . I believe there is a bug, but I are not able to fix it.