This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
Add OpenGraph annotations #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs #34 to be merged before anything useful will show up. And we will need to add cover images for some other pages - noticably the front page of lowrisc.org |
imphil
reviewed
Nov 15, 2019
| @@ -17,7 +17,10 @@ | |||
| <link href="{{ relURL . }}" rel="stylesheet"> | |||
| {{ end }} | |||
|
|
|||
| {{ block "analytics" . }}{{ partial "analytics" . }}{{end}} | |||
| {{ template "_internal/google_analytics.html" . }} | |||
|
We also probably want a "social header" image for lowrisc to use by default (and on the homepage) before we merge this. Something like this one that was made for OT: https://opentitan.org/opentitan.png |
|
@lenary what's the status of this one? Should we take it as-is? |
|
It's waiting on a "social header" image before I do final polish, unless you think we should go without for the moment. |
|
Let's do without it for now. |
|
I picked the Google Analytics-related parts from this PR and pushed it to master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, refactor header contents
Fixes #33
I need to check all the pages (especially the front page), but this should be correct.