[quality] Update repository quality suite #15044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
requested review from
arunthomas,
drewmacrae,
timothytrippel and
milesdai
|
Oh, irony: The |
cfrantz
force-pushed
the
quality
branch
2 times, most recently
from
f1d07ce to
d6bb7fd
Compare
timothytrippel
approved these changes
Sep 21, 2022
Signed-off-by: Chris Frantz <[email protected]>
1. Move `clang_format_{check,fix}` to the `quality` subdir.
2. Execute `clang_format_check` as a test.
Signed-off-by: Chris Frantz <[email protected]>
milesdai
approved these changes
Sep 21, 2022
drewmacrae
approved these changes
Sep 22, 2022
| # Directories used exclusively to store build artifacts are still copied into. | ||
| "./build-out/**", | ||
| "./build-bin/**", | ||
| # fusesoc build dir |
There was a problem hiding this comment.
Nit: I think the docs also get built in build
There was a problem hiding this comment.
I'm not sure what the suggestion is here. This was copied directly from the prior incarnation in the root BUILD file.
These excludes are slated for deletion once we get the CI doing everything through bazel.
Signed-off-by: Chris Frantz <[email protected]>
Signed-off-by: Chris Frantz <[email protected]>
eunchan
added a commit
to eunchan/opentitan
that referenced
this pull request
Sep 24, 2022
PR lowRISC#15044 did not update bazel airgap environment prep script. Signed-off-by: Eli Kim <[email protected]>
eunchan
added a commit
to eunchan/opentitan
that referenced
this pull request
Sep 24, 2022
PR lowRISC#15044 did not update bazel airgap environment prep script. Signed-off-by: Eli Kim <[email protected]>
timothytrippel
pushed a commit
that referenced
this pull request
Sep 24, 2022
PR #15044 did not update bazel airgap environment prep script. Signed-off-by: Eli Kim <[email protected]>
timothytrippel
added a commit
to timothytrippel/opentitan
that referenced
this pull request
Sep 26, 2022
Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
added a commit
to timothytrippel/opentitan
that referenced
this pull request
Sep 26, 2022
This updates the way the go toolchain is downloaded/included in our Bazel workspace to enable Bazel builds in an airgapped environment. Specifically, lowRISC#15044 exposed a bug in our go toolchain dependency that caused Bazel builds to fail in the airgapped environment. The fix for this was two fold: 1. manually specify the exact toolchain tarballs to be downloaded using the `go_download_sdk` repo rule, instead of the `go_register_toolchain` rule which attempts to automatically find the right toolchain to download by downloading a file from the Internet that is not cacheable, and therefore not accessible in an airgapped environment, and 2. fork and patch `rules_go` to only download go toolchains using the `ctx.download_and_extract` action (instead of the `ctx.download` action) which caches said downloads in the repository cache that is moved to the airgapped environment. See lowRISC/rules_go@07fe5f4 for more details. Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
added a commit
to timothytrippel/opentitan
that referenced
this pull request
Sep 26, 2022
This updates the way the go toolchain is downloaded/included in our Bazel workspace to enable Bazel builds in an airgapped environment. Specifically, lowRISC#15044 exposed a bug in our go toolchain dependency that caused Bazel builds to fail in the airgapped environment. The fix for this was two fold: 1. manually specify the exact toolchain tarballs to be downloaded using the `go_download_sdk` repo rule, instead of the `go_register_toolchain` rule which attempts to automatically find the right toolchain to download by downloading a file from the Internet that is not cacheable, and therefore not accessible in an airgapped environment, and 2. fork and patch `rules_go` to only download go toolchains using the `ctx.download_and_extract` action (instead of the `ctx.download` action) which caches said downloads in the repository cache that is moved to the airgapped environment. See lowRISC/rules_go@07fe5f4 for more details. Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
added a commit
to timothytrippel/opentitan
that referenced
this pull request
Sep 26, 2022
This updates the way the go toolchain is downloaded/included in our Bazel workspace to enable Bazel builds in an airgapped environment. Specifically, lowRISC#15044 exposed a bug in our go toolchain dependency that caused Bazel builds to fail in the airgapped environment. The fix for this was two fold: 1. manually specify the exact toolchain tarballs to be downloaded using the `go_download_sdk` repo rule, instead of the `go_register_toolchain` rule which attempts to automatically find the right toolchain to download by downloading a file from the Internet that is not cacheable, and therefore not accessible in an airgapped environment, and 2. fork and patch `rules_go` to only download go toolchains using the `ctx.download_and_extract` action (instead of the `ctx.download` action) which caches said downloads in the repository cache that is moved to the airgapped environment. See lowRISC/rules_go@07fe5f4 for more details. Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
added a commit
to timothytrippel/opentitan
that referenced
this pull request
Sep 27, 2022
This updates the way the go toolchain is downloaded/included in our Bazel workspace to enable Bazel builds in an airgapped environment. Specifically, lowRISC#15044 exposed a bug in our go toolchain dependency that caused Bazel builds to fail in the airgapped environment. The fix for this was to manually specify the exact toolchain tarballs to be downloaded using the `go_download_sdk` repo rule, instead of the `go_register_toolchain` rule which attempts to automatically find the right toolchain to download by downloading a file from the Internet that is not cacheable, since no sha256 is provided to the `ctx.download` action, and therefore not accessible in an airgapped environment. Signed-off-by: Timothy Trippel <[email protected]>
timothytrippel
added a commit
that referenced
this pull request
Sep 27, 2022
This updates the way the go toolchain is downloaded/included in our Bazel workspace to enable Bazel builds in an airgapped environment. Specifically, #15044 exposed a bug in our go toolchain dependency that caused Bazel builds to fail in the airgapped environment. The fix for this was to manually specify the exact toolchain tarballs to be downloaded using the `go_download_sdk` repo rule, instead of the `go_register_toolchain` rule which attempts to automatically find the right toolchain to download by downloading a file from the Internet that is not cacheable, since no sha256 is provided to the `ctx.download` action, and therefore not accessible in an airgapped environment. Signed-off-by: Timothy Trippel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the "quality" suite for the OpenTitan repository.
TL;DR:
bazel test //quality/...bazel run <some_check>to insteadbazel test <some_check> --test_output=streamed.testinvocation and new labels.This change should not be committed until after lowRISC/misc-linters#30.