[prim,fpv] Fix binding in prim_esc_rxtx_fpv #24450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bind statement had a typo which meant that it didn't actually bind in any assertions. Found by analysing formal coverage. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
added
Component:FPV
With the wrong names, Jasper (quite reasonably) throws a warning saying that these are unknown/unbound variables, then drives them with arbitrary inputs. This code can never have been correct, and the FPV assertions would see counterexample traces if the binding was correct (fixed in the previous commit). Signed-off-by: Rupert Swarbrick <[email protected]>
The stray exclamation mark caused a failure (because the implied cover property was not possible). Signed-off-by: Rupert Swarbrick <[email protected]>
alees24
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bind statement had a typo which meant that it didn't actually bind in any assertions. Found by analysing formal coverage.