-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sival/aes] Introduce AES Stall Status Bit test #25564
Merged
engdoreis
merged 1 commit into
lowRISC:master
from
github-gcontributor:vt_checkins_stall_new
Dec 11, 2024
Merged
[sival/aes] Introduce AES Stall Status Bit test #25564
engdoreis
merged 1 commit into
lowRISC:master
from
github-gcontributor:vt_checkins_stall_new
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-gcontributor
requested review from
moidx
and removed request for
a team
December 10, 2024 02:52
I couldn't re-open the PR#25082. |
github-gcontributor
force-pushed
the
vt_checkins_stall_new
branch
from
December 10, 2024 03:29
a671722
to
398ec8f
Compare
engdoreis
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR with the fixes below LGTM.
This commit introduces the AES stall test (chip_sw_stall_test) to verify the stall bit getting asserted when scenario of back pressure is created. - Intial Checkin: sw/device/tests/aes_stall_test.c - Updated File: sw/device/tests/BUILD - Updated File: hw/top_earlgrey/data/ip/chip_aes_testplan.hjson - Implemented changes as per review comments from engdoreis and nasahlpa - Re-opening accidently closed PR#25082 did not work - Attempt to create new PR - Resolving conflit Signed-off-by: Varunkumar Trivedi <[email protected]>
github-gcontributor
force-pushed
the
vt_checkins_stall_new
branch
from
December 10, 2024 21:52
398ec8f
to
87b3123
Compare
nasahlpa
approved these changes
Dec 11, 2024
engdoreis
approved these changes
Dec 11, 2024
engdoreis
added
the
CherryPick:earlgrey_1.0.0
This PR should be cherry-picked to earlgrey_1.0.0
label
Dec 11, 2024
Successfully created backport PR for |
Git push to origin failed for earlgrey_1.0.0 with exitcode 1 |
github-actions
bot
added
the
Manually CherryPick
This PR should be manually cherry picked.
label
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CherryPick:earlgrey_1.0.0
This PR should be cherry-picked to earlgrey_1.0.0
Manually CherryPick
This PR should be manually cherry picked.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the AES stall test (chip_sw_stall_test) to
verify the stall bit getting asserted when scenario of back pressure
is created.