Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sival/aes] Introduce AES Stall Status Bit test #25564

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

github-gcontributor
Copy link
Contributor

This commit introduces the AES stall test (chip_sw_stall_test) to
verify the stall bit getting asserted when scenario of back pressure
is created.

  • Intial Checkin: sw/device/tests/aes_stall_test.c
  • Updated File: sw/device/tests/BUILD
  • Updated File: hw/top_earlgrey/data/ip/chip_aes_testplan.hjson
  • Implemented changes as per review comments from engdoreis and nasahlpa
  • Re-opening accidently closed PR#25082 did not work
  • Attempt to create new PR

@github-gcontributor github-gcontributor requested a review from a team as a code owner December 10, 2024 02:52
@github-gcontributor github-gcontributor requested review from moidx and removed request for a team December 10, 2024 02:52
@github-gcontributor
Copy link
Contributor Author

I couldn't re-open the PR#25082.
Hence, created a new PR#25564
#25564
Let me know if this works.

Copy link
Contributor

@engdoreis engdoreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR with the fixes below LGTM.

hw/top_earlgrey/data/ip/chip_aes_testplan.hjson Outdated Show resolved Hide resolved
hw/top_earlgrey/data/ip/chip_aes_testplan.hjson Outdated Show resolved Hide resolved
This commit introduces the AES stall test (chip_sw_stall_test) to
 verify the stall bit getting asserted when scenario of back pressure
is created.

- Intial Checkin: sw/device/tests/aes_stall_test.c
- Updated File: sw/device/tests/BUILD
- Updated File: hw/top_earlgrey/data/ip/chip_aes_testplan.hjson
- Implemented changes as per review comments from engdoreis and nasahlpa
- Re-opening accidently closed PR#25082 did not work
- Attempt to create new PR
- Resolving conflit

Signed-off-by: Varunkumar Trivedi <[email protected]>
@engdoreis engdoreis merged commit 7fd8634 into lowRISC:master Dec 11, 2024
37 checks passed
@engdoreis engdoreis added the CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0 label Dec 11, 2024
Copy link

Successfully created backport PR for earlgrey_1.0.0:

Copy link

Git push to origin failed for earlgrey_1.0.0 with exitcode 1

@github-actions github-actions bot added the Manually CherryPick This PR should be manually cherry picked. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0 Manually CherryPick This PR should be manually cherry picked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants