[pentest] Update EDN SCA tests #25619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
requested review from
HU90m
and removed request for
a team and
HU90m
nasahlpa
added
the
CherryPick:earlgrey_1.0.0
This commit updates the EDN SCA tests to use asm instead of C code such that the SCA target is more accurate. Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Alexander Wagner <[email protected]>
nasahlpa
force-pushed
the
update_edn_sca
branch
from
034eb18 to
058acb2
Compare
vogelpi
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Thanks for the PR @nasahlpa . The code looks good to me but I have a question regarding the analysis method:
Before this PR we had a fixed-vs-random command wheres with this PR we only have the command for measuring the transmission of one word over the bus. I assume we then do the trace grouping during the analysis based on individual subwords or even bits we want to analyze. Can you comment on this please?
|
Yes exactly, the analysis needs to be done at the host site. The reason for this change is that the lab decided that this will fit their setup better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the EDN SCA tests to use asm instead of C code such that the SCA target is more accurate.