Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SiVal, usbdev] Suspend and Resume test. #25728

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Conversation

engdoreis
Copy link
Contributor

This PR is based on the PR: #23200

@engdoreis engdoreis force-pushed the usbdev branch 5 times, most recently from ed94e27 to a5b84ee Compare December 23, 2024 12:58
@engdoreis engdoreis added the CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0 label Dec 23, 2024
@engdoreis engdoreis marked this pull request as ready for review December 23, 2024 15:46
@engdoreis engdoreis requested review from a team as code owners December 23, 2024 15:46
@engdoreis engdoreis requested review from jwnrt, HU90m, pamaury, luismarques and alees24 and removed request for a team and HU90m December 23, 2024 15:46
alees24 and others added 5 commits January 7, 2025 10:36
Add a simple host-side application to drive the suspend-
sleep-resume top-level USBDEV tests.

Signed-off-by: Adrian Lees <[email protected]>
Changes to the usb_testutils layer to report link events
as required by the suspend-resume top-level tests.
Extend the usb_testutils_streams code to construct a
USB configuration descriptor from the list of transfer
types, permitting a single test to be more configurable.

Signed-off-by: Adrian Lees <[email protected]>
Suspend-resume library code used in a number of top-level
tests for exercising the various combinations of suspend/sleep
states and USB stimuli.
Individual top-level tests are very compact and just walk
through shortened sequences of test phases to make chip-level
simulation times feasible.
Presently configured for ES USBDEV, but also supporting Prod.

Signed-off-by: Adrian Lees <[email protected]>
Suspend-sleep-resume testing of USBDEV involves multiple
test phases, states and stimuli, to check the DUT response
to Resume Signaling, Bus Reset or VBUS loss during each of
powered, Normal Sleep and Deep Sleep states.

Signed-off-by: Adrian Lees <[email protected]>
@engdoreis
Copy link
Contributor Author

engdoreis commented Jan 7, 2025

@jwnrt, I have removed the #ifdef from the DIF since the USBDEV_WAKE_EVENTS_BUS_NOT_IDLE_BIT. Is supported on master.

Copy link
Contributor

@jwnrt jwnrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

The software team at lowRISC discussed this and decided that even though the diff is large and we couldn't review it all in depth, we're better off with the test coverage than without.

The non-test change to the DIF looks fine.

@engdoreis engdoreis merged commit c4a5642 into lowRISC:master Jan 8, 2025
38 checks passed
@engdoreis engdoreis deleted the usbdev branch January 8, 2025 10:34
Copy link

github-actions bot commented Jan 8, 2025

Successfully created backport PR for earlgrey_1.0.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants