Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hw,prim_ram_1p,rtl] Add reset input to prim_ram_1p #25736

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Dec 20, 2024

A reset input is reasonable as the underlying macro might need a reset signal for internal flops.

@Razer6 Razer6 requested a review from a team as a code owner December 20, 2024 20:54
@Razer6 Razer6 requested review from eshapira, a-will and andreaskurth and removed request for a team and eshapira December 20, 2024 20:54
@Razer6 Razer6 force-pushed the prim-ram-reset branch 6 times, most recently from 2e86941 to 46c89ca Compare December 23, 2024 12:38
@Razer6 Razer6 added the CI:Rerun Rerun failed CI jobs label Dec 23, 2024
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Dec 23, 2024
@andreaskurth
Copy link
Contributor

CHANGE AUTHORIZED: hw/ip/prim/rtl/prim_ram_1p_adv.sv
CHANGE AUTHORIZED: hw/ip/prim_generic/rtl/prim_generic_flash_bank.sv
CHANGE AUTHORIZED: hw/ip/prim_generic/rtl/prim_generic_ram_1p.sv
CHANGE AUTHORIZED: hw/ip/prim_xilinx/rtl/prim_xilinx_ram_1p.sv
CHANGE AUTHORIZED: hw/ip/prim_xilinx_ultrascale/rtl/prim_xilinx_ultrascale_ram_1p.sv
CHANGE AUTHORIZED: hw/vendor/lowrisc_ibex/rtl/ibex_top.sv

This adds a reset input to prim_ram_1p and connects it in the modules that instantiate it. No functional change (implementations that didn't make use of a reset before won't have it connected anyways).

@a-will
Copy link
Contributor

a-will commented Dec 23, 2024

CHANGE AUTHORIZED: hw/ip/prim/rtl/prim_ram_1p_adv.sv
CHANGE AUTHORIZED: hw/ip/prim_generic/rtl/prim_generic_flash_bank.sv
CHANGE AUTHORIZED: hw/ip/prim_generic/rtl/prim_generic_ram_1p.sv
CHANGE AUTHORIZED: hw/ip/prim_xilinx/rtl/prim_xilinx_ram_1p.sv
CHANGE AUTHORIZED: hw/ip/prim_xilinx_ultrascale/rtl/prim_xilinx_ultrascale_ram_1p.sv
CHANGE AUTHORIZED: hw/vendor/lowrisc_ibex/rtl/ibex_top.sv

A reset input is reasonable as the underlying macro might need
a reset signal for internal flops.

Signed-off-by: Robert Schilling <[email protected]>
@andreaskurth andreaskurth merged commit 7648c5b into lowRISC:master Dec 25, 2024
38 checks passed
@Razer6 Razer6 deleted the prim-ram-reset branch December 25, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants