[hmac,dv] Skip msg_length check when reset #25738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martin-velay
commented
Dec 23, 2024
martin-velay
commented
- when a reset a is happening, the HMAC DV env is not really robust. Some tasks are still ongoing and would require to be killed. A temporary fix has been proposed to skip the msg_length check when a Save and Restore task is ongoing when a reset is triggered. A better approach will be put in place later when a proper reset agent will be used.
martin-velay
force-pushed
the
fix_msg_length_rst
branch
3 times, most recently
from
7a2634a to
12d259c
Compare
rswarbrick
reviewed
Dec 28, 2024
- when a reset a is happening, the HMAC DV env is not really robust. Some tasks are still ongoing and would require to be killed. A temporary fix has been proposed to skip the msg_length check when a Save and Restore task is ongoing when a reset is triggered. A better approach will be put in place later when a proper reset agent will be used. Signed-off-by: Martin Velay <[email protected]>
martin-velay
force-pushed
the
fix_msg_length_rst
branch
from
12d259c to
42b8106
Compare
|
I have added the TODO and created an issue to track this : #25809 |
rswarbrick
approved these changes
Jan 8, 2025
rswarbrick
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.