Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick to earlgrey_1.0.0: [Opentitantool] Add a ftdi transport to the opentitanlib. #25786

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Cherry-pick to earlgrey_1.0.0: [Opentitantool] Add a ftdi transport to the opentitanlib. #25786

merged 4 commits into from
Jan 7, 2025

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 7, 2025

This is an automatic cherry-pick of #25645 to branch earlgrey_1.0.0.

@engdoreis @github-actions
[rust] Add new dependencies to opentitanlib
5076d70 
The new dependencies will be used to implement a new transport that will
use a ftdi chip to bootstrap a opentitan chip.

Signed-off-by: Douglas Reis <[email protected]>
(cherry picked from commit 7e141a7)
@engdoreis @github-actions
[opentitanlib] Add ftdi transport for voyager board
43dc095 
Signed-off-by: Douglas Reis <[email protected]>
(cherry picked from commit 42c8ab0)
@engdoreis @github-actions
[opentitanlib] Add gpio implementation for ftdi transport
1bb761c 
Signed-off-by: Douglas Reis <[email protected]>
(cherry picked from commit dcd643b)
@engdoreis @github-actions
[opentitanlib] Add spi implementation for ftdi transport
8164c20 
Signed-off-by: Douglas Reis <[email protected]>
(cherry picked from commit 46f5fc6)
@github-actions github-actions bot requested a review from a team as a code owner January 7, 2025 10:02
@github-actions github-actions bot requested review from jon-flatley and removed request for a team January 7, 2025 10:02
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Merged
@engdoreis engdoreis merged commit 8db33e1 into earlgrey_1.0.0 Jan 7, 2025
@engdoreis engdoreis deleted the backport-25645-to-earlgrey_1.0.0 branch January 7, 2025 16:15
@timothytrippel
Copy link
Contributor

timothytrippel commented Jan 7, 2025 •
edited
Loading

@engdoreis this seems to break builds of opentitanlib this branch:

ERROR: /usr/local/google/home/ttrippel/repos/opentitan/earlgrey_1.0.0/sw/host/opentitanlib/BUILD:57:13: no such target '@crate_index//:embedded-hal': target 'embedded-hal' not declared in package '' defined by /usr/local/google/home/ttrippel/.cache/bazel/_bazel_ttrippel/0cec6938a54dbfbd0f897b5079e1fdc0/external/crate_index/BUILD.bazel (Tip: use `query "@crate_index//:*"` to see all the targets in that package) and referenced by '//sw/host/opentitanlib:opentitanlib'
ERROR: /usr/local/google/home/ttrippel/repos/opentitan/earlgrey_1.0.0/sw/host/opentitanlib/BUILD:57:13: no such target '@crate_index//:ftdi-embedded-hal': target 'ftdi-embedded-hal' not declared in package '' defined by /usr/local/google/home/ttrippel/.cache/bazel/_bazel_ttrippel/0cec6938a54dbfbd0f897b5079e1fdc0/external/crate_index/BUILD.bazel (Tip: use `query "@crate_index//:*"` to see all the targets in that package) and referenced by '//sw/host/opentitanlib:opentitanlib'
ERROR: /usr/local/google/home/ttrippel/repos/opentitan/earlgrey_1.0.0/sw/host/opentitanlib/BUILD:57:13: no such target '@crate_index//:ftdi-mpsse': target 'ftdi-mpsse' not declared in package '' defined by /usr/local/google/home/ttrippel/.cache/bazel/_bazel_ttrippel/0cec6938a54dbfbd0f897b5079e1fdc0/external/crate_index/BUILD.bazel (Tip: use `query "@crate_index//:*"` to see all the targets in that package) and referenced by '//sw/host/opentitanlib:opentitanlib'
ERROR: Analysis of aspects '[@rules_rust//rust:defs.bzl%rust_clippy_aspect, //rules:quality.bzl%modid_check_aspect] with parameters {} on //third_party/rust:crate_index' failed; build aborted:
INFO: Elapsed time: 42.225s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (127 packages loaded, 922 targets configured)
    currently loading: @crate_index__serde-1.0.189// ... (15 packages)

I have a fix, one moment.

timothytrippel added a commit to timothytrippel/opentitan that referenced this pull request Jan 7, 2025
@timothytrippel
[rust] update crate index after manifest changed
0adfc5d 
PR lowRISC#25786 updated the Rust crates used the project but did not update
the crate index, thus breaking opentitanlib builds. This runs `bazel run
//third_party/rust:crate_index -- --repin` to fix the issue.

Signed-off-by: Tim Trippel <[email protected]>
@timothytrippel timothytrippel mentioned this pull request Jan 7, 2025
Closed
@timothytrippel
Copy link
Contributor

#25801 will fix

@timothytrippel
Copy link
Contributor

Looks like that fix was not enough; in order for this PR to be cherry-picked to earlgrey_1.0.0, #25259 also be cherry picked. @engdoreis did this pass CI before you merged this?

@timothytrippel timothytrippel mentioned this pull request Jan 7, 2025
Closed
@timothytrippel
Copy link
Contributor

timothytrippel commented Jan 7, 2025 •
edited
Loading

@engdoreis I think the simplest thing to do is to revert these changes first to unblock this branch, then make the necessary fixes. #25803 should do so.

@timothytrippel timothytrippel mentioned this pull request Jan 7, 2025
Merged
@engdoreis engdoreis mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engdoreis engdoreis engdoreis approved these changes

@jon-flatley jon-flatley Awaiting requested review from jon-flatley jon-flatley is a code owner automatically assigned from lowRISC/ot-rust-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timothytrippel @engdoreis