Cherry-pick to earlgrey_1.0.0: [crypto] Fix the KMAC-KDF implementation to return the output in shares. #25789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Previously, the KMAC driver always unmasked the shares of the digest returned by the KMAC block. This is OK for hash functions like SHA-3, but problematic for KMAC-KDF where the output is key material. The implementation also did not modify the second half of the keyblob buffer in KMAC-KDF, which would cause correctness issues if those values were not initialized to zero. This commit refactors the KMAC driver to allow returning the digest in masked form, and adjusts KMAC-KDF to use this new capability. Signed-off-by: Jade Philipoom <[email protected]> (cherry picked from commit c676ed8)
github-actions
bot
requested review from
jadephilipoom
and removed request for
a team
moidx
approved these changes
Jan 16, 2025
|
@jadephilipoom. I closed and re-opened this PR to trigger a CI run. For some reason the results from the previous run were not available. |
|
Looks like the "build documentation" and "cw340 manufacturing test" checks are failing -- I re-ran them, but it looks like it might be unrelated, given that the latest run of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic cherry-pick of #25780 to branch
earlgrey_1.0.0.