[hsmtool] Support SPHINCS+ in CloudKMS #25857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
force-pushed
the
hsmtool-kms
branch
2 times, most recently
from
015a62c to
833faa4
Compare
cfrantz
force-pushed
the
hsmtool-kms
branch
3 times, most recently
from
71a27ee to
19a09e0
Compare
I typo'ed the formal sphincs+ algorithm names as `SLA-DSA-...` when they should have been `SLH-DSA-...`. Signed-off-by: Chris Frantz <[email protected]>
Rename the `spxef` module to `extra::spxef` as we'll be adding more custom backends into the `extra` module. Signed-off-by: Chris Frantz <[email protected]>
Signed-off-by: Chris Frantz <[email protected]>
Some HSMs perform the domain preparation as part of their API, and thus we should not perform domain preparation on the data sent to the HSM. 1. Remove domain prepration from the `SignData` preparation function. 2. Add domain preparation to the acorn backend. 3. Pass the domain parameter to the sphincsplus reference implementation sign/verify functions. Signed-off-by: Chris Frantz <[email protected]>
1. Use the CloudKMS REST/json API to perform SPHINCS+ signing. Signed-off-by: Chris Frantz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the CloudKMS REST/json API to perform SPHINCS+ signing.