[kmac, sival] Keymgr-state-agnostic kmac_sideload_functest
#25898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-caforio
requested review from
jadephilipoom
and removed request for
a team
engdoreis
approved these changes
Jan 16, 2025
engdoreis
added
the
CherryPick:earlgrey_1.0.0
jadephilipoom
approved these changes
Jan 16, 2025
This commit fixes the two `kmac_sideload_functest` tests that were
failing due to a misconfigured key version parameter. Some ROMs set
the max key version in the keymgr to 0, which causes sideloading to
abort if any other version value is being programmed. Note that the
proper functioning of valid/invalid keymgr version numbers is part of
the `chip_sw_keymgr_derive_{sealing, attestation}` tests.
This bug has been mentioned as part of lowRISC#21706.
Signed-off-by: Andrea Caforio <[email protected]>
andrea-caforio
force-pushed
the
keymgr-state-agnostic-kmac-sideload-functest
branch
from
2821eda to
77d0fa9
Compare
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the two
kmac_sideload_functesttests that were failing due to a misconfigured key version parameter. Some ROMs set the max key version in the keymgr to 0, which causes sideloading to abort if any other version value is being programmed. Note that the proper functioning of valid/invalid keymgr version numbers is part of thechip_sw_keymgr_derive_{sealing, attestation}tests.This bug has been mentioned as part of #21706.