Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hmac,dv] Reset S&R skip context #25899

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[hmac,dv] Reset S&R skip context #25899

merged 1 commit into from
Jan 17, 2025

Conversation

martin-velay
Copy link
Contributor

  • reinitialize the Save and Restore skip context flag each time the HMAC is in reset.

@martin-velay
[hmac,dv] Reset S&R skip context
1757fc6 
- reinitialize the Save and Restore skip context flag each time the
  HMAC is in reset.

Signed-off-by: Martin Velay <[email protected]>
@martin-velay martin-velay self-assigned this Jan 16, 2025
@martin-velay martin-velay added Component:DV DV issue: testbench, test case, etc. IP:hmac labels Jan 16, 2025
@martin-velay martin-velay marked this pull request as ready for review January 16, 2025 10:19
@martin-velay martin-velay requested a review from a team as a code owner January 16, 2025 10:19
rswarbrick
rswarbrick reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, but I'm slightly surprised to see it in the base vseq when the "client" is actually the scoreboard. Shouldn't this be in the monitor?

@martin-velay
Copy link
Contributor Author

Both SCB and vseq need this signal, but that's a temporary thing as mentioned in a TODO #23562

@rswarbrick
Copy link
Contributor

Ahah, that makes sense. Thanks for explaining it (and I'm glad the tidy-up is being tracked).

@rswarbrick rswarbrick merged commit 2b174a1 into lowRISC:master Jan 17, 2025
38 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rswarbrick rswarbrick rswarbrick approved these changes

@marcelocarvalhoLowRisc marcelocarvalhoLowRisc Awaiting requested review from marcelocarvalhoLowRisc

Assignees

@martin-velay martin-velay

Labels
Component:DV DV issue: testbench, test case, etc. IP:hmac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-velay @rswarbrick