[tlul,rtl] Avoid an unnecessary wready signal in tlul_adapter_sram #25905
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DataXorAddr is true, there are two fifos that hold SRAM requests (u_sramreqfifo and u_sramreqaddrfifo). These will always push and pop in sync (using the same signals in fact!). As such, checking both wready signals is unnecessary. Drop one, avoiding an impossible conditional coverage item. Signed-off-by: Rupert Swarbrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DataXorAddr is true, there are two fifos that hold SRAM requests (u_sramreqfifo and u_sramreqaddrfifo). These will always push and pop in sync (using the same signals in fact!).
As such, checking both wready signals is unnecessary. Drop one, avoiding an impossible conditional coverage item.