[rom] Update clkmgr jitter enable to match ROM specification. #26027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ROM e2e plan captures the expected behavior of the clock jitter enable flow: > `CREATOR_SW_CFG_JITTER_EN`: `kMultiBitBool4False` disables, all other values > enables. `CREATOR_SW_CFG_AST_INIT_EN` must also be `kMultiBitBool4True` to enable. This change refactors the code in `rom_start.S` and `test_rom_start.S` to explicitly reduce any value different than MubiFalse to MubiTrue. The implementation relies on the register to be reset to MubiFalse by default. Signed-off-by: Miguel Osorio <[email protected]>
cfrantz
approved these changes
Jan 27, 2025
timothytrippel
approved these changes
Jan 27, 2025
matutem
reviewed
Jan 28, 2025
| @@ -170,12 +170,17 @@ _start: | |||
| andi t0, t0, 0x1 | |||
| beqz t0, .L_ast_done_loop | |||
|
|
|||
| // Enable jittery clock if enabled in OTP. | |||
| // Enable jittery clock if not strictly disabled in OTP. | |||
| // Use hardcoded MULTIBIT_ASM_BOOL4_TRUE as the enable word to reduce all | |||
There was a problem hiding this comment.
Do you mean "Use MULTIBIT_ASM_BOOL4_FALSE as the disable word to reduce all other possible OTP values to enable."
There was a problem hiding this comment.
I meant to use the MULTIBIT_ASM_BOOL4_TRUE word as the write value to reduce all other options to True (Enable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ROM e2e plan captures the expected behavior of the clock jitter enable flow:
This change refactors the code in
rom_start.Sandtest_rom_start.Sto explicitly reduce any value different than MubiFalse to MubiTrue. The implementation relies on the register to be reset to MubiFalse by default.