[dv,mem_bkdr_util] Memory back door specializations #26045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
reviewed
Jan 28, 2025
|
@Razer6: Since you're looking at this util at the same time, could you take a look at this? Will the interaction with your changes be reasonable? |
alees24
force-pushed
the
mem-bkdr-util
branch
from
6aaf64c to
907853b
Compare
Modify the mem_bkdr_util class to remove the specialized functionality for flash, ROM and SRAM and migrate these operations into extended classes. This is somewhat cleaner and more elegant, and also helps with Darjeeling since there is no flash controller in that design. Update block- and top-level DV environments to use the new classes and to remove explicit specializations for Rom access from `chip_sw_base_vseq.` Signed-off-by: Adrian Lees <[email protected]>
alees24
force-pushed
the
mem-bkdr-util
branch
from
907853b to
d9b8f3d
Compare
Looks good to me. I only have a small conflict I need to rebase. Go for it! |
Razer6
approved these changes
Jan 28, 2025
rswarbrick
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the mem_bkdr_util class to migrate the specialized functionality for flash, ROM and SRAM into extended classes.
This is somewhat cleaner and more elegant, and also helps with Darjeeling since there is no flash controller in that design.
Update block- and top-level DV environments to use the new classes and to remove explicit specializations for Rom access from
chip_sw_base_vseq.This PR has been tested by running a number of top_earlgrey chip simulations, rom_ctrl block-level tests and sram_ctrl block-level tests, but do please consider whether other uses may have been overlooked.