[sival/hmac] Add Hmac error conditions Test #26049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rprakas-gsc
requested review from
HU90m,
moidx and
nasahlpa
and removed request for
a team
Open
nasahlpa
reviewed
Jan 29, 2025
rprakas-gsc
force-pushed
the
earlgrey_1.0.0
branch
from
3eedde8 to
138b180
Compare
Signed-off-by: Ramesh Prakash <[email protected]> Add HMAC error condition test as per chip_hmac_testplan.hjson Incorporated feedback from PR
rprakas-gsc
force-pushed
the
earlgrey_1.0.0
branch
from
138b180 to
e09f7af
Compare
|
@rprakas-gsc could you please create a separat PR for the commit that you have added after my review? The reason is that I have only approved the first commit (which you also have modified after my review). |
|
Hi Pascal,
That was a mistake. Yes, I m in the process of resetting it to the
previous commit and create a new PR for the new commit!
Thanks,
Ramesh
…On Thu, Jan 30, 2025 at 12:36 PM Pascal Nasahl ***@***.***> wrote:
@rprakas-gsc <https://github.com/rprakas-gsc> could you please create a
separat PR for the commit that you have added after my review? The reason
is that I have only approved the first commit (which you also have modified
after my review).
—
Reply to this email directly, view it on GitHub
<#26049 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJEK246LXPPAPL7EKIVHML32NKEM7AVCNFSM6AAAAABWBHG6W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRVGUZDINJRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@nasahlpa - I did git reset to the previous commit - and force push to the earlgrey_1.0.0 origin. Hope this fixes. After this merge is successful, I will create a new PR for hmac_endianness_test. Thanks, Ramesh |
rprakas-gsc
force-pushed
the
earlgrey_1.0.0
branch
2 times, most recently
from
5ae6210 to
7802064
Compare
|
@nasahlpa - I do see the merge is still blocked even though all CI tests have passed. Do you know what is causing this ? |
|
Thanks @rprakas-gsc! I think merging only can be done by certain people, I think @engdoreis can help. |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ramesh Prakash [email protected]
Add HMAC error condition test as per chip_hmac_testplan.hjson