This repository has been archived by the owner on May 26, 2023. It is now read-only.
Allow identical joins only once #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
Jud
force-pushed
the
pheasant-ignore-multiple-join-attempts
branch
from
98f9a7b to
a1f9515
Compare
|
Can you rebase this? |
|
@Jud can you rebase this to master? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multiple loosely coupled methods that pass around unexecuted
Collectionobjects and join/filter as they need. It's possible to get into a situation where multiple methods need to join a table, but can't be certain whether it has or has not been joined.This only allows distinct join statements -- which makes it easier to have more loosely coupled methods that pass around Collections.