Make asynchronous download optional #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should hopefully fix the newest issue mentioned in lozuponelab/AMON#9 ? At least it does on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like KEGG has increased the "cool down" period after forbidding a user for making too many requests. With this being the case, the strategy of "try to download in parallel unless KEGG stops us, then switch to non-parallel downloading" doesn't really work due to this new "cool down" period.
Now, the downloader has a
try_asyncargument which can be disabled to skip the attempt to download in parallel.Version also bumped.
Also REACTION added to fields not captured, since that was erroring.