Re-export hyper_rustls from yup #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will publish a new version later this week. Thanks for this suggestion and PR. |
Merged
lquerel
pushed a commit
that referenced
this pull request
Apr 28, 2024
Since yup_oauth2 structs are used as parameters in public functions, it is an error if consumer uses different version of yup_oauth than gcp-bigquery-client, export yup_oauth2 so consumers don't need to carefully keep their dependency versions in sync This also allows accessing yup_oauth2::hyper_rustls, as suggested in #85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a suggestion but you could re-export rustls from yup instead of depending on it directly