Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Inverted editor layout #322

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

matthiaslehnertum
Copy link
Collaborator

@matthiaslehnertum matthiaslehnertum commented Nov 19, 2023

As per Stephan's request, this PR flips the layout of the Apollon Editor to have the component sidebar on the left side of the editor canvas.

Checklist

  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes
  • I translated all the newly inserted strings into German and English

Motivation and Context

To make Apollon more similar to other editor applications, the component sidebar is moved to the left side.

Steps for Testing

Open up Apollon, see if the sidebar is correctly rendered on the left side of the editor canvas and make sure paddings within the application seem correctly sized.

Screenshots

Screenshot 2023-11-19 at 22 25 53

Copy link
Contributor

@loreanvictor loreanvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine. I personally preferred the menu on the other side 😅 but I checked with various similar diagram editing software and the positioning of the menus is not consistent, so I suppose its a matter of preference. perhaps it would be nice if we could break the menu into two parts: keeping the general menu (diagram type, language, etc) on the left while having the elements menu on the right, which would result in a more balanced layout of the page instead of being skewed to the side (but I suspect thats up for discussion and then a follow-up PR).

@matthiaslehnertum matthiaslehnertum marked this pull request as ready for review November 27, 2023 10:31
@matthiaslehnertum matthiaslehnertum merged commit b524d20 into develop Nov 27, 2023
4 checks passed
@matthiaslehnertum matthiaslehnertum deleted the feature/layout-adaption branch November 27, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants