Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I translated all the newly inserted strings into German and English(NA)Motivation and Context
A common feature of realtime collaboration is highlighting elements and relationships selected by some other collaborator. Currently this is implemented via a
selectedBy
property on elements, which has the downside that this ephemeral state will be persisted alongside the diagram, potentially leading to corrupt diagram data (a collaborator marked as selecting an element might not be present anymore).It is notable that currently highlighting relationships selected by a remote collaborator is not possible as well.
Description
This PR will add a property to model state, independent of the exported diagram, called
remoteSelection
, alongside two new APIs for Apollon:👆 This method highlights given elements and relationships, for given collaborator (marked by their name and color), or removes their corresponding highlighting from given deselected elements.
👆 This method removes any remote selector not in the allowed list.
Steps for Testing
/diagrams
folder exists (btw this should be added to the README of standalone).You should:
Test Coverage
Screenshots