Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Redux to version 5.0.1 #355

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Upgrade Redux to version 5.0.1 #355

wants to merge 18 commits into from

Conversation

matthiaslehnertum
Copy link
Collaborator

@matthiaslehnertum matthiaslehnertum commented May 9, 2024 •
edited
Loading

Motivation and Context

This PR upgrades the version of Redux used in Apollon to the latest version 5.0.1.

Description

Updating Redux to the latest version unfortunately required quite a few changes to be made. In the current setup, types are converted to any in quite a few places which will require more changes in follow-up PRs to be resolved properly.

@matthiaslehnertum matthiaslehnertum changed the title Remove usages of the DeepPartial type for upgrading the Redux version Upgrade Redux to version 5.0.1 May 9, 2024
krusche
krusche requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@krusche krusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casting types to any is not an ideal solution. Is there no other way?

@egenerse
Copy link

can you update these files?

 1  src/main/packages/uml-component-diagram/uml-component-subsystem/uml-component-subsystem.ts:1
 1  src/main/packages/uml-component-diagram/uml-component/uml-component-component.ts:3
 1  src/main/packages/uml-deployment-diagram/uml-deployment-component/uml-component.ts:1

@loreanvictor
Copy link
Contributor

@matthiaslehnertum is this still ongoing? do you have any idea why the build is failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krusche krusche Awaiting requested review from krusche

@loreanvictor loreanvictor Awaiting requested review from loreanvictor

@egenerse egenerse Awaiting requested review from egenerse

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiaslehnertum @egenerse @loreanvictor @krusche