Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

48 object diagram extension #92

Merged
merged 5 commits into from
Feb 3, 2025
Merged

48 object diagram extension #92

merged 5 commits into from
Feb 3, 2025

Conversation

egenerse
Copy link
Collaborator

@egenerse egenerse commented Feb 2, 2025

Checklist

  • I linked PR with a related issue
  • I added multiple screenshots/screencasts of my UI changes

Motivation and Context

User can create Object diagrams

This PR completes #48

Description

Dropped element configuration is updated to cover more diagram types
The library can handle more diagram types
New diagrams can be created in different types

Steps for Testing

  1. Create a new diagram as an Object Diagram
  2. Edit it
  3. Export it
  4. Create a new diagram
  5. Import exported diagram
  6. See new diagram extension

Screenshots

Screen.Recording.2025-02-02.at.13.31.51.mov

@egenerse egenerse self-assigned this Feb 2, 2025
@egenerse egenerse linked an issue Feb 2, 2025 that may be closed by this pull request
@egenerse egenerse requested a review from kurunbelemir February 2, 2025 12:35
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works however when I left the node clicked it appears in the exported image. It is a minor issue. I checked in APollon it doesnt appear. Should we change i?
Object Diagram (1).pdf
Object Diagram

@egenerse egenerse requested a review from kurunbelemir February 3, 2025 14:03
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job. Thanks for quick fix.

@egenerse egenerse merged commit fc15b0f into main Feb 3, 2025
2 checks passed
@egenerse egenerse deleted the 48-object-diagram-extension branch February 3, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object Diagram Extension
2 participants