74 Add Edge Toolbar and Edge Pop Over for Editing Edges #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
egenerse
requested changes
Feb 3, 2025
There was a problem hiding this comment.
- Bidirectional edge target edge is off from the node.
- Custom Edge toolbar doesn't disappear when I click out
- Change edge direction changes connected handles
- Source and target multiplicity role placements are over nodes
- After selecting new edge type popover closes, it should remain open
Screen.Recording.2025-02-03.at.21.02.13.mov
library/lib/components/toolbars/edgeToolBar/CustomEdgeToolBar.tsx
Outdated
Show resolved
Hide resolved
library/lib/components/toolbars/edgeToolBar/CustomEdgeToolBarProps.ts
Outdated
Show resolved
Hide resolved
Comment on lines
121
to
122
| onMouseEnter={() => setIsHovered(true)} | ||
| onMouseLeave={() => setIsHovered(false)} |
There was a problem hiding this comment.
Do we need these state handlers for hover? Can't we define a class and add it to the app.css file to handle hover from there?
…ange hooks to update edge function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
As a user, I would like to be able to change my edge types, swap my target and source ends of my path, specifiy role and multiplicity of the path ends so that I can show realionship between the components.
This PR completes https://github.com/ls1intum/Apollon2/issues/xx
Description
Custom Toolbar and Popover is created.
Toolbar contains edit and delete icons.
Popover is used for Edge type changes, target-source swap, Role and Multiplicity Label.
Color functionality will be added later on.
Steps for Testing
Screenshots