Caching and UPDATED-sorting for the Github Data Sync Algorithm (#94)

Co-authored-by: Felix T.J. Dietrich <[email protected]>
ls1intum · Sep 18, 2024 · ca9e577 · ca9e577
1 parent 0f893bb
commit ca9e577
Show file tree

Hide file tree

Showing 14 changed files with 312 additions and 128 deletions.
diff --git a/server/application-server/openapi.yaml b/server/application-server/openapi.yaml
@@ -232,6 +232,9 @@ components:
         updatedAt:
           type: string
           format: date-time
+        number:
+          type: integer
+          format: int32
         title:
           type: string
         url:
@@ -450,11 +453,36 @@ components:
           type: integer
           format: int32
         changesRequested:
-          type: integer
-          format: int32
+          type: array
+          items:
+            $ref: "#/components/schemas/PullRequestReviewDTO"
         approvals:
-          type: integer
-          format: int32
+          type: array
+          items:
+            $ref: "#/components/schemas/PullRequestReviewDTO"
         comments:
+          type: array
+          items:
+            $ref: "#/components/schemas/PullRequestReviewDTO"
+    PullRequestReviewDTO:
+      type: object
+      properties:
+        id:
           type: integer
-          format: int32
+          format: int64
+        createdAt:
+          type: string
+          format: date-time
+        updatedAt:
+          type: string
+          format: date-time
+        submittedAt:
+          type: string
+          format: date-time
+        state:
+          type: string
+          enum:
+          - COMMENTED
+          - APPROVED
+          - CHANGES_REQUESTED
+          - DISMISSED
diff --git a/...on-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequest.java b/...on-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequest.java
@@ -30,6 +30,9 @@
 @NoArgsConstructor
 @ToString(callSuper = true)
 public class PullRequest extends BaseGitServiceEntity {
+
+    private int number;
+
     @NonNull
     private String title;
 

diff --git a/.../src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequestConverter.java b/.../src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequestConverter.java
@@ -20,6 +20,7 @@ public PullRequest convert(@NonNull GHPullRequest source) {
         IssueState state = convertState(source.getState());
         PullRequest pullRequest = new PullRequest();
         convertBaseFields(source, pullRequest);
+        pullRequest.setNumber(source.getNumber());
         pullRequest.setTitle(source.getTitle());
         pullRequest.setUrl(source.getHtmlUrl().toString());
         pullRequest.setState(state);

diff --git a/...in/java/de/tum/in/www1/hephaestus/codereview/pullrequest/review/PullRequestReviewDTO.java b/...in/java/de/tum/in/www1/hephaestus/codereview/pullrequest/review/PullRequestReviewDTO.java
@@ -0,0 +1,10 @@
+package de.tum.in.www1.hephaestus.codereview.pullrequest.review;
+
+import java.time.OffsetDateTime;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+
+@JsonInclude(JsonInclude.Include.NON_EMPTY)
+public record PullRequestReviewDTO(Long id, OffsetDateTime createdAt, OffsetDateTime updatedAt,
+        OffsetDateTime submittedAt, PullRequestReviewState state) {
+}
diff --git a/...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/LeaderboardEntry.java b/...lication-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/LeaderboardEntry.java
@@ -1,6 +1,8 @@
 package de.tum.in.www1.hephaestus.leaderboard;
 
 import com.fasterxml.jackson.annotation.JsonInclude;
+
+import de.tum.in.www1.hephaestus.codereview.pullrequest.review.PullRequestReviewDTO;
 import de.tum.in.www1.hephaestus.codereview.user.UserType;
 import lombok.AllArgsConstructor;
 import lombok.Getter;
@@ -19,7 +21,7 @@ public class LeaderboardEntry {
         private UserType type;
         private int score;
         private int rank;
-        private int changesRequested;
-        private int approvals;
-        private int comments;
+        private PullRequestReviewDTO[] changesRequested;
+        private PullRequestReviewDTO[] approvals;
+        private PullRequestReviewDTO[] comments;
 }
diff --git a/...cation-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/LeaderboardService.java b/...cation-server/src/main/java/de/tum/in/www1/hephaestus/leaderboard/LeaderboardService.java
@@ -1,17 +1,24 @@
 package de.tum.in.www1.hephaestus.leaderboard;
 
+import java.time.OffsetDateTime;
+import java.time.ZoneOffset;
 import java.util.ArrayList;
 import java.util.Comparator;
+import java.util.Date;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Objects;
+import java.util.Set;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.stream.Collectors;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.stereotype.Service;
 
 import de.tum.in.www1.hephaestus.codereview.pullrequest.PullRequest;
+import de.tum.in.www1.hephaestus.codereview.pullrequest.review.PullRequestReviewDTO;
 import de.tum.in.www1.hephaestus.codereview.user.User;
 import de.tum.in.www1.hephaestus.codereview.user.UserService;
 import de.tum.in.www1.hephaestus.codereview.user.UserType;
@@ -22,6 +29,9 @@ public class LeaderboardService {
 
     private final UserService userService;
 
+    @Value("${monitoring.timeframe}")
+    private int timeframe;
+
     public LeaderboardService(UserService userService) {
         this.userService = userService;
     }
@@ -32,32 +42,47 @@ public List<LeaderboardEntry> createLeaderboard() {
         List<User> users = userService.getAllUsers();
         logger.info("Found " + users.size() + " users");
 
+        OffsetDateTime cutOffTime = new Date(System.currentTimeMillis() - 1000 * 60 * 60 * 24 * timeframe)
+                .toInstant().atOffset(ZoneOffset.UTC);
+
         List<LeaderboardEntry> leaderboard = users.stream().map(user -> {
             if (user.getType() != UserType.USER) {
                 return null;
             }
-            int comments = user.getIssueComments().size();
-            AtomicInteger changesRequested = new AtomicInteger(0);
-            AtomicInteger changesApproved = new AtomicInteger(0);
+            logger.info("User: " + user.getLogin());
             AtomicInteger score = new AtomicInteger(0);
-            user.getReviews().stream().forEach(review -> {
-                switch (review.getState()) {
-                    case CHANGES_REQUESTED:
-                        changesRequested.incrementAndGet();
-                        break;
-                    case APPROVED:
-                        changesApproved.incrementAndGet();
-                        break;
-                    default:
-                        break;
-                }
-                score.addAndGet(calculateScore(review.getPullRequest()));
-            });
+            Set<PullRequestReviewDTO> changesRequestedSet = new HashSet<>();
+            Set<PullRequestReviewDTO> approvedSet = new HashSet<>();
+            Set<PullRequestReviewDTO> commentSet = new HashSet<>();
+
+            user.getReviews().stream()
+                    .filter(review -> (review.getCreatedAt() != null && review.getCreatedAt().isAfter(cutOffTime))
+                            || (review.getUpdatedAt() != null && review.getUpdatedAt().isAfter(cutOffTime)))
+                    .forEach(review -> {
+                        if (review.getPullRequest().getAuthor().getLogin().equals(user.getLogin())) {
+                            return;
+                        }
+                        PullRequestReviewDTO reviewDTO = new PullRequestReviewDTO(review.getId(), review.getCreatedAt(),
+                                review.getUpdatedAt(), review.getSubmittedAt(), review.getState());
+                        switch (review.getState()) {
+                            case CHANGES_REQUESTED:
+                                changesRequestedSet.add(reviewDTO);
+                                break;
+                            case APPROVED:
+                                approvedSet.add(reviewDTO);
+                                break;
+                            default:
+                                commentSet.add(reviewDTO);
+                                break;
+                        }
+                        score.addAndGet(calculateScore(review.getPullRequest()));
+                    });
             return new LeaderboardEntry(user.getLogin(), user.getAvatarUrl(), user.getName(), user.getType(),
                     score.get(),
                     0, // preliminary rank
-                    changesRequested.get(),
-                    changesApproved.get(), comments);
+                    changesRequestedSet.toArray(new PullRequestReviewDTO[changesRequestedSet.size()]),
+                    approvedSet.toArray(new PullRequestReviewDTO[approvedSet.size()]),
+                    commentSet.toArray(new PullRequestReviewDTO[commentSet.size()]));
         }).filter(Objects::nonNull).collect(Collectors.toCollection(ArrayList::new));
 
         // update ranks by score