#82: remove PRNumber, add custom card colors

ls1intum · Sep 20, 2024 · de37865 · de37865
1 parent e887425
commit de37865
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/...on-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequest.java b/...on-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequest.java
@@ -33,9 +33,6 @@ public class PullRequest extends BaseGitServiceEntity {
     @NonNull
     private String url;
 
-    @NonNull
-    private int prNumber;
-
     /**
      * State of the PullRequest.
      * Does not include the state of the merge.

diff --git a/.../src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequestConverter.java b/.../src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequestConverter.java
@@ -28,7 +28,6 @@ public PullRequest convert(@NonNull GHPullRequest source) {
         pullRequest.setTitle(source.getTitle());
         pullRequest.setUrl(source.getHtmlUrl().toString());
         pullRequest.setState(state);
-        pullRequest.setPrNumber(source.getNumber());
         pullRequest.setPullRequestLabels(convertLabels(source.getLabels()));
         try {
             pullRequest.setAdditions(source.getAdditions());

diff --git a/webapp/src/app/ui/app-issue-card/app-issue-card.component.html b/webapp/src/app/ui/app-issue-card/app-issue-card.component.html
@@ -1,7 +1,7 @@
-<div class="border border-gray-300 rounded-lg p-4 w-72">
+<div class="border border-border bg-card rounded-lg p-4 w-72">
   <div class="flex justify-between items-center mb-2 text-xs text-gray-500">
     <span class="font-bold flex justify-center items-center space-x-1">
-      <ng-icon [svg]="octGitPullRequest" size="16" class="mr-1"></ng-icon> {{ pullRequest().repository.name }} #{{ pullRequest().number }} on {{ pullRequest().createdAt }}
+      <ng-icon [svg]="octGitPullRequest" size="16" class="mr-1"></ng-icon> {{ pullRequest().repository?.name }} #{{ pullRequest().number }} on {{ pullRequest().createdAt }}
     </span>
     <span class="flex items-center space-x-2">
       <span class="text-github-success-foreground font-bold">+{{ pullRequest().additions }}</span>