Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeframe filter confusing when initially opening the leaderboard #107

Closed
b-fein opened this issue Oct 1, 2024 · 1 comment · Fixed by #108 or #110
Closed

Timeframe filter confusing when initially opening the leaderboard #107

b-fein opened this issue Oct 1, 2024 · 1 comment · Fixed by #108 or #110
Assignees
Labels
bug Something isn't working priority:high Crucial tasks needing prompt attention.

Comments

@b-fein
Copy link

b-fein commented Oct 1, 2024

Describe the bug
When initially opening the leaderboard, it still looks like the time frame selector is applied. However, when switching to another time frame and back again to the original one, different data is shown (and now the browser URL shows the from/to URL parameters).
I therefore suspect the filter is not applied when loading the page initially.

Expected behavior
The UI should make clear that the filter is not yet applied (e.g. by having an empty dropdown option) since the current behaviour is confusing and is not clear if the filter is already applied on first page load or not.

Screenshots
URL is https://hephaestus.ase.cit.tum.de/ without parameters, but filter looks like is is active:
image
Data in the table does not seem to be filtered, however.

Additional context
Add any other context about the problem here.

@GODrums
Copy link
Contributor

GODrums commented Oct 2, 2024

Thank you for noticing this!

Yes, you are completely correct about your assumption. The initial leaderboard (no params) currently displays the past 7 days.
This will be addressed in a fix ASAP!

@GODrums GODrums added bug Something isn't working priority:high Crucial tasks needing prompt attention. labels Oct 2, 2024
@GODrums GODrums self-assigned this Oct 2, 2024
@GODrums GODrums linked a pull request Oct 2, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high Crucial tasks needing prompt attention.
Projects
None yet
2 participants