Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Initial Leaderboard filter params #108

Conversation

GODrums
Copy link
Contributor

@GODrums GODrums commented Oct 2, 2024

Motivation

Closes #107.

Description

We now use the current week as default whenever there are no query params. This should have been part of the original PR #105, but I must have missed it.
It also fixes the Dayjs package version, which got merged with a ^ in #92.

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Changes have been tested locally
  • Self-review of the code has been done
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

@GODrums GODrums added bug Something isn't working priority:high Crucial tasks needing prompt attention. labels Oct 2, 2024
@GODrums GODrums self-assigned this Oct 2, 2024
@GODrums GODrums linked an issue Oct 2, 2024 that may be closed by this pull request
@github-actions github-actions bot added client size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 2, 2024
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelixTJDietrich FelixTJDietrich merged commit 432391b into develop Oct 2, 2024
5 checks passed
@FelixTJDietrich FelixTJDietrich deleted the 107-timeframe-filter-confusing-when-initially-opening-the-leaderboard branch October 2, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client priority:high Crucial tasks needing prompt attention. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeframe filter confusing when initially opening the leaderboard
2 participants