Leaderboard: Custom Sliding Time Window

[GODrums]

Motivation

We want to be able to set custom timeframes for the leaderboard. This allows us to create sliding time windows with custom dates for the client.

Description

This PR adds support for custom sliding time windows in both the server- and client-side:

• before and after timestamps, both usable standalone or combined
• Server-side via @RequestParam
• Client-side via URL query params

Example URL: http://localhost:4200/?after=2024-09-18T10:15:30%2001:00&before=2024-09-20T10:15:30%2001:00
-> sets after to: 2024-09-19 10:15:30 UTC +1
-> sets before to: 2024-09-20 10:15:30 UTC +1

In the future, this should be combined with UI elements (e.g. button, range-slider) to allow the visitor of the website to filter the timeframe they would like to see.

Checklist

General

• PR title is clear and descriptive
• PR description explains the purpose and changes
• Code follows project coding standards
• Self-review of the code has been done
• Changes have been tested locally

Client (if applicable)

• UI changes look good on all screen sizes and browsers
• No console errors or warnings
• User experience and accessibility have been tested
• Added Storybook stories for new components
• Components follow design system guidelines (if applicable)

Server (if applicable)

• Code is performant and follows best practices
• No security vulnerabilities introduced
• Proper error handling has been implemented
• Added tests for new functionality
• Changes have been tested in different environments (if applicable)

[FelixTJDietrich]

I think user.getReviews could already support querying by timeframe.

[GODrums]

So if I understand your idea correctly, you would like to do the filtering in the SQL-Query already?

That's a great idea for performance improvements, I will take a look at it.

[GODrums]

I tried out a Query like this:

SELECT u
FROM User u
JOIN FETCH u.pullRequests 
JOIN FETCH u.issueComments
JOIN FETCH u.reviewComments
JOIN FETCH u.reviews re
WHERE re.createdAt between :after and :before
OR re.updatedAt between :after and :before

but it doesn't seem to return any results, most likely I'm missing something regarding the format conversion.

[GODrums]

Managed to find the correct SQL query to filter the dates.
With 63c434d, we now filter directly in the DB.

[FelixTJDietrich]

Maybe we should round to the beginning of the day?

[FelixTJDietrich]

Or what happens with 2024-09-10? I guess it will use midnight, then it might be important for the after case. If you for example use 2024-09-15 as before I think it should get all timestamps before the end of day. So actually we would need to round up?

[GODrums]

If no timestamp is provided, it should default to midnight, yes.

While I personally find different default timestamps for before and after confusing, I do see why this would be expected behavior for users. Will change it 👍

[GODrums]

Had a look through Java best practices and found this sheet: https://i.sstatic.net/WyAl2.png

Equivalently to your idea, after and before are now only dates (LocalDate - without timestamp) with an interpretation as the start and end of the day on the server respectively. Also looks much cleaner in the URL (example: http://localhost:4200/?after=2024-09-21&before=2024-09-23).

Implemented this change in b76ed6d.

[FelixTJDietrich]

Code LGTM, thank you! 😄