Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Review and Reviewed PR Count to Leaderboard Activity #104

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

GODrums
Copy link
Contributor

@GODrums GODrums commented Sep 25, 2024

Motivation

Currently, the activity column of the leaderboard lists a developer's reviews grouped by the review's state. In order to give an even better activity overview, we are also interested in the total number of reviewed PRs and number of distinct reviewed PRs.

Description

Adds new "summary" elements to the activity column of the leaderboard consisting of:

  • Number of Reviews: Sum of all reviews independent of state (includes dismissed reviews)
  • Number of reviewed PRs: Count of PRs, which have been reviewed at least once
  • Separator via the chevronRight icon

Screenshots (if applicable)

image

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented
  • Added tests for new functionality
  • Changes have been tested in different environments (if applicable)

@GODrums GODrums added enhancement New feature or request client labels Sep 25, 2024
@GODrums GODrums self-assigned this Sep 25, 2024
@github-actions github-actions bot added application-server size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 25, 2024
@GODrums GODrums linked an issue Sep 25, 2024 that may be closed by this pull request
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@FelixTJDietrich FelixTJDietrich merged commit e0c3fd3 into develop Oct 1, 2024
5 checks passed
@FelixTJDietrich FelixTJDietrich deleted the leaderboard-pr-count branch October 1, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server client enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include reviewed PRs count in leaderboard
3 participants