Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Spartan as UI component library #109

Merged
merged 18 commits into from
Oct 3, 2024

Conversation

FelixTJDietrich
Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich commented Oct 3, 2024

Motivation

We don't want to implement everything ourselves and Spartan/ui is in a relatively good state. Spartan also supports signals and zoneless AFAICS.

Description

  • Add all components from Spartan in src/libs/ui
  • Replace current components with the ones from Spartan (except for table since our's seems better)
  • Minor UI improvements

Screenshots (if applicable)

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

@github-actions github-actions bot added client size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 3, 2024
@FelixTJDietrich FelixTJDietrich merged commit 83940ad into develop Oct 3, 2024
4 checks passed
@FelixTJDietrich FelixTJDietrich deleted the chore/refactor-to-spartan branch October 3, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant