Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup FastAPI Intelligence Service #47

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

milesha
Copy link
Contributor

@milesha milesha commented Aug 11, 2024

Description

Set up of the FastAPI for the further integration of LLM

Summary

  • Set folder structure for the intelligence assistant
  • Created the "Hello World" API endpoint
  • Added documentation

Motivation

FastAPI service is used for interfacing LangChain and other ML services in the further implementation.

Related Issue

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented
  • Added tests for new functionality
  • Changes have been tested in different environments (if applicable)

Screenshots (if applicable)

Attach screenshots here.

@milesha milesha added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 11, 2024
@milesha milesha self-assigned this Aug 11, 2024
@github-actions github-actions bot added intelligence-service feature size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 11, 2024
@FelixTJDietrich FelixTJDietrich removed the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 11, 2024
Copy link
Contributor

@GODrums GODrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, took me quite a while to get the correct Python version and Poetry set up on Win11. Looks good though!

2. **Run the application:**
You can start the FastAPI application with Uvicorn:
```bash
poetry run uvicorn src.main:app --reload
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me might want to improve this in the future so it is just poetry run intelligence-service or so

Copy link
Collaborator

@FelixTJDietrich FelixTJDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FelixTJDietrich FelixTJDietrich merged commit 00c6173 into develop Aug 14, 2024
2 of 3 checks passed
@FelixTJDietrich FelixTJDietrich deleted the feature/set-up-intelligence-service branch August 14, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature intelligence-service size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants