Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41985: Fix handling of offline nodes. #971

Merged
merged 1 commit into from
Dec 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/sqre/infra/jenkins_node_cleanup.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -398,8 +398,10 @@ void processNodes() {
// executors.
def computer = node.toComputer()

// a null channel indicates that the node is offline
if (computer == null || computer.isOffline()) {
if (computer == null) {
// a null channel indicates that the node is offline
throw new Offline(node)
} else if (computer.isOffline()) {
// check if previous run screwed up
if (computer.getOfflineCauseReason().startsWith('disk cleanup from job')) {
// ignore it and clear it at the end
Expand Down
Loading