DM-47973: Support Keda in MiddlewareInterface._get_deployment #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-47973
branch
2 times, most recently
from
a1abcc1 to
7b7c217
Compare
The deployment ID is environment-dependent and relies on external cues. Logging it at debug level will help prevent surprises.
kfindeisen
force-pushed
the
tickets/DM-47973
branch
from
7b7c217 to
d0be0cf
Compare
This environment variable allows the deployment ID to be set by Phalanx or Argo.
Turn off K_REVISION.
kfindeisen
force-pushed
the
tickets/DM-47973
branch
from
d0be0cf to
8705548
Compare
This reverts commit 8705548.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dummy PR for testing deployment management.