-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fleet/dashboards) fix some dashboards and add new ones #387
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments including screenshots are in this thread on slack: https://lsstc.slack.com/archives/C05JLDDAPAR/p1715360161601749
The commit message also contains a typo: "dashboars" |
I've cleaned up a lot of dashboards to bring them back into working state I believe. The only 2 broken parts are the |
The grafana dashboards are using specific datasources in the first design. This causes the UUID to break when importing these through provisioning files into other grafana instances. The fix for this is to use a datasource variable. Signed-off-by: Francis Begyn <[email protected]>
4343112
to
a2ef94f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only a partial re-review. There are still 8 remain dashboards I haven't look at yet and won't have time to look at until tomorrow morning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have completed inspect all dashboard within this PR and made comments where I have concerns. WRT the Ceph dashboards. If the titles are direct copies of upstream dashboards, I think its OK to not rename them to have "Ceph" in the title but I think they need to be in a Ceph (or Rook) folder to logically group them together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't currently have rgw zone replication enabled on any cluster. We have tested it in the past and will probably use it later this year. It currently isn't possible to test with dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…han cluster labels
Use the correct key for the secret instead of the older one.
@KrisBuytaert @fbegyn What is the status of this PR? Is it ready for re-review? |
The grafana dashboards are using specific datasources in the first design. This causes the UUID to break when importing these through provisioning files into other grafana instances. The fix for this is to use a datasource variable.