(fleet/rook-ceph-conf) add rsphome export for manke #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbarria
added
enhancement
cbarria
requested review from
jhoblitt,
csilva-cl,
dtapiacl,
igonzalezcl and
badenerb
jhoblitt
reviewed
Sep 4, 2024
| failureDomain: host | ||
| erasureCoded: | ||
| dataChunks: 6 | ||
| codingChunks: 3 |
There was a problem hiding this comment.
This seems large for a 10 node cluster with fault tolerance of 2. 6+2 is probably safer. I wonder if 5+3 is a good idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket was developed on another branch that never got merged(pre-fleet), so I noticed this while cleaning old branches.
this is the same NFS but for Fleet.
need help checking this line
ceph nfs export create cephfs rsphome /rsphome rsphomenot sure if it is the correct creation path (if it matches the current one)
(I think it is good, but it would be great if someone else could check this, as this is already in production)