(fleet/kuma) deploy a temporary kuma dev monitoring instance #633
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtapiacl
requested review from
jhoblitt,
cbarria,
gseriche,
csilva-cl,
igonzalezcl and
badenerb
jhoblitt
requested changes
Oct 18, 2024
| kubernetes.io/ingress.class: nginx | ||
| nginx.ingress.kubernetes.io/backend-protocol: HTTP | ||
| nginx.ingress.kubernetes.io/server-snippet: | | ||
| proxy_ssl_verify off; |
There was a problem hiding this comment.
This isn't necessary unless using HTTPS as the backend protocol.
There was a problem hiding this comment.
Ok, I will clean up line 7.
| nginx.ingress.kubernetes.io/backend-protocol: HTTP | ||
| nginx.ingress.kubernetes.io/server-snippet: | | ||
| proxy_ssl_verify off; | ||
| nginx.ingress.kubernetes.io/proxy-read-timeout: "3600" |
There was a problem hiding this comment.
Is an hour long timeout needed?
| enabled: true | ||
| annotations: | ||
| cert-manager.io/cluster-issuer: letsencrypt | ||
| kubernetes.io/ingress.class: nginx |
There was a problem hiding this comment.
This annotation is deprecated and we should try to stop using it for new bundles. Does the chart support setting ingressClassName ?
There was a problem hiding this comment.
I think it does based on the source code:
I will update the code to use that instead.
| enabled: true | ||
| accessMode: ReadWriteOnce | ||
| size: 4Gi | ||
| existingClaim: "" |
There was a problem hiding this comment.
I would prefer so if possible, as i did not find a persistence key on the values chart.
jhoblitt
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be "temporary", yes i know we don't like to use that word around here.